We did not check `val ~= nil` in the resolve functions, so config like
`{ nil, max = 30 }` will throw a nil error. Also, if the config is `{
padding = _ }`, the logic relies on the function handling the padding is
iterated before the one handling min/max in the map, which is not always
guaranteed.
Fix the bug by adding nil check in the function handling min/max. Close
* fix(notify): don't report request on new line
* ref(notify): update message format
* ref(msgs): always quote values + decrease duplication
* fix(ci): undefined variables
* ref(actions): temporary silent actions.__index errors
* cleanup
* revert: panic effort, we continue to use error for those
Co-authored-by: Simon Hauser <Simon-Hauser@outlook.de>
* wip: 2021-07-22 15:00 BST
* wip: `horizontal` refactored
* wip: `center` refactored
* wip: `cursor` and `vertical` refactored
* wip: `current_buffer` refactor
- also changed `layout_config_defaults` as they gave errors when using `current_buffer`
* wip: `bottom_pane` refactor
* [docgen] Update doc/telescope.txt
skip-checks: true
* fix: put accidentally remove config option back
* [docgen] Update doc/telescope.txt
skip-checks: true
* wip: standardise `height` calculation for `center` and `bottom_pane`
* wip: improve comments
* [docgen] Update doc/telescope.txt
skip-checks: true
* stylua
- also fix a merge mistake
* [docgen] Update doc/telescope.txt
skip-checks: true
* fix: attempt to fix bad merge
* refactor: remove unused entry in `borderchars` table
- also fix some typos
* wip: tweak padding for `bottom_pane`
* wip: add `tabline` checks to `bottom_pane`
- also tweaked position so that `statusline` is not covered when borders are enabled
* stylua
* refactor: factor out size capping function
* [docgen] Update doc/telescope.txt
skip-checks: true
* fix: adjust tests that relied on height being number of results
* fix: forgot variable in calc_size_and_spacing
* fix: maybe this fixes these tests?
* test: try other plenary branch for ci
* test: switch back to main plenary branch for ci
* fix: actually define `max_results` in the test
* fix: final tweaks for edge cases
Co-authored-by: Github Actions <actions@github>
Started adding `resolve` which will allow you to do some really nice
stuff easily with options to get the window options from a variety of
inputs.
You can see how we do it in pickers.lua for borders & borderchars
currently.
