Rename and simplify make_entry function

lua/telescope/builtin.lua

@@ -499,7 +499,7 @@ builtin.help_tags = function(opts)
     prompt_title = 'Help',
     finder = finders.new_table {
       results = tags,
-      entry_maker = make_entry.gen_from_tagfile(opts),
+      entry_maker = make_entry.gen_from_taglist(opts),
     },
     -- TODO: previewer for Vim help
     previewer = previewers.help.new(opts),

lua/telescope/make_entry.lua

@@ -365,24 +365,16 @@ function make_entry.gen_from_treesitter(opts)
   end
 end
 
-function make_entry.gen_from_tagfile(_)
+function make_entry.gen_from_taglist(_)
   local delim = string.char(9)
 
-  local make_display = function(line)
-    local help_entry = (line..delim):match("(.-)" .. delim)
-    return {
-      display = help_entry,
-      value = help_entry
-    }
-  end
-
   return function(line)
     local entry = {}
-    local d = make_display(line)
-    entry.valid   = next(d) ~= nil
-    entry.display = d.display
-    entry.value   = d.value
-    entry.ordinal = d.value
+    local tag = (line..delim):match("(.-)" .. delim)
+    entry.valid   = tag ~= ""
+    entry.display = tag
+    entry.value   = tag
+    entry.ordinal = tag
 
     return entry
   end