1a1d7ecb73
* perf: avoid creating closure in cache.ensure and drop some cached getters This mainly addresses the perf issue on large amount of calls to `entry.new`. Previously every `cache.ensure` calls in the code path of it creates an anonymous function, and it seems that luajit just could not inline it. Function creation is not expensive in luajit, but that overhead is noticeable if every `cache.ensure` call creates a function. The first improvemnt is to solidate the cache callback and attach it to the metatable of `entry`. This ensures that every created entry instance share the same cache callback and no new functions will be frequently created, reduces the ram usage and GC overhead. To improve it further, some frequently accessed fields of entry like `completion_item` and `offset` is refactored to use simple table access instead of getter pattern. The current cached getter is implemented using `cache.ensure`, which introduces two more levels of function calls on each access: `cache.key` and `cache.get`. The overhead is okay if but noticeable if entries amount is quite large: you need to call 4 functions on a simple `completion_item` field access for each item. All of the changes done in the commit is just constant time optimization. But the different is huge if tested with LS providing large amount of entries like tailwindcss. * perf: delay fuzzy match on displayed vim item `entry.get_vim_item` is a very heavy call, especially when user do complex stuff on item formatting. Delay its call to window displaying to let `performance.max_view_entries` applied to it. * remove unneeded fill_defaults * update gha --------- Co-authored-by: hrsh7th <629908+hrsh7th@users.noreply.github.com>
61 lines
1.1 KiB
Lua
61 lines
1.1 KiB
Lua
---@class cmp.Cache
|
|
---@field public entries any
|
|
local cache = {}
|
|
|
|
cache.new = function()
|
|
local self = setmetatable({}, { __index = cache })
|
|
self.entries = {}
|
|
return self
|
|
end
|
|
|
|
---Get cache value
|
|
---@param key string|string[]
|
|
---@return any|nil
|
|
cache.get = function(self, key)
|
|
key = self:key(key)
|
|
if self.entries[key] ~= nil then
|
|
return self.entries[key]
|
|
end
|
|
return nil
|
|
end
|
|
|
|
---Set cache value explicitly
|
|
---@param key string|string[]
|
|
---@vararg any
|
|
cache.set = function(self, key, value)
|
|
key = self:key(key)
|
|
self.entries[key] = value
|
|
end
|
|
|
|
---Ensure value by callback
|
|
---@generic T
|
|
---@param key string|string[]
|
|
---@param callback fun(...): T
|
|
---@return T
|
|
cache.ensure = function(self, key, callback, ...)
|
|
local value = self:get(key)
|
|
if value == nil then
|
|
local v = callback(...)
|
|
self:set(key, v)
|
|
return v
|
|
end
|
|
return value
|
|
end
|
|
|
|
---Clear all cache entries
|
|
cache.clear = function(self)
|
|
self.entries = {}
|
|
end
|
|
|
|
---Create key
|
|
---@param key string|string[]
|
|
---@return string
|
|
cache.key = function(_, key)
|
|
if type(key) == 'table' then
|
|
return table.concat(key, ':')
|
|
end
|
|
return key
|
|
end
|
|
|
|
return cache
|