leigh/neogen
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(python): Check for assignment to non-attributes in class (#107)

Browse Source
This commit is contained in:
root
2022-11-03 00:07:40 +01:00
parent c9ee823ec2
commit da04629ffa
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lua/neogen/configurations/python.lua
View File

@@ -224,15 +224,23 @@ return {
return {} return {}
end end
-- Deliberately check inside the init function for assignments to "self"
results[i.ClassAttribute] = {} results[i.ClassAttribute] = {}
for _, assignment in pairs(nodes["assignment"]) do for _, assignment in pairs(nodes["assignment"]) do
local left_side = assignment:field("left")[1] -- Getting left side in assignment
local left_attribute = left_side:field("attribute")[1] local left = assignment:field("left")
-- Checking if left side is an "attribute", which means assigning to an attribute to the function
if not vim.tbl_isempty(left) and not vim.tbl_isempty(left[1]:field("attribute")) then
--Adding it to the list
local left_attribute = assignment:field("left")[1]:field("attribute")[1]
left_attribute = helpers.get_node_text(left_attribute)[1] left_attribute = helpers.get_node_text(left_attribute)[1]
if left_attribute and not vim.startswith(left_attribute, "_") then
if not vim.startswith(left_attribute, "_") then
table.insert(results[i.ClassAttribute], left_attribute) table.insert(results[i.ClassAttribute], left_attribute)
end end
end end
end
if vim.tbl_isempty(results[i.ClassAttribute]) then if vim.tbl_isempty(results[i.ClassAttribute]) then
results[i.ClassAttribute] = nil results[i.ClassAttribute] = nil
end end